-
Notifications
You must be signed in to change notification settings - Fork 26
[CI/BUILD] Use build cache for Spyre tests #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update GH workflow for Spyre tests to ... - build and cache a test image - use the cached test image for both v0 and v1 tests - run v0 and v1 tests in parallel - Add build stages to Dockerfile, with separate stage for tests - Add .dockerignore Signed-off-by: Christian Kadner <[email protected]>
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Now you are good to go 🚀 |
I updated the TODO list in the PR description (initial comment)
|
Signed-off-by: Christian Kadner <[email protected]>
564490c
to
1079461
Compare
@joerunde -- I am done with my intended changes and removed draft status for this PR. Would you kindly give it another review? |
@ckadner are we still planning on merging this, or moving to a non-docker approach instead? |
@joerunde I have a Either of them take about a minute longer than this Docker based version (when cached) 😄 🤷🏻 🤯 I don't know what other platforms we may want to test on in the future. Sticking with Docker, we could use cross-platform compilation to build and test Z/OS images. |
Close in favor of #70 |
Changes in this PR:
test-spyre
as merge requirementRemove
test-spyre
:Add
test-spyre-v0
andtest-spyre-v1
:Optional:
Resolves #34