Skip to content

Conversation

prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Sep 3, 2025

Description

Print relative tolerance diff in tests

   token id. token               logprob         token id. token               logprob
HF:       32 -                   -0.727358  vLLM:       32 -                   -0.756990
HF:      203 -                   -0.104307  vLLM:      203 -                   -0.104083
HF:      203 -                   -0.000012  vLLM:      203 -                   -0.000013
HF:     1482 -                   -0.021897  vLLM:     1482 -                   -0.022218
HF:     5170 -                   -0.000252  vLLM:     5170 -                   -0.000263
HF:       44 -                   -0.000222  vLLM:       44 -                   -0.000238
HF:      203 -                   -0.000062  vLLM:      203 -                   -0.000112  ERROR (REL_TOL_DIFF = 45.05%)

Signed-off-by: Prashant Gupta <[email protected]>
Copy link

github-actions bot commented Sep 3, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 changed the title 🎨 print relative tolerance 🎨 print relative tolerance diff in tests Sep 3, 2025
@prashantgupta24 prashantgupta24 marked this pull request as ready for review September 3, 2025 23:02
@prashantgupta24 prashantgupta24 marked this pull request as draft September 3, 2025 23:27
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️

@prashantgupta24 prashantgupta24 marked this pull request as ready for review September 4, 2025 16:14
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) September 4, 2025 16:14
@github-actions github-actions bot added the ready label Sep 4, 2025
@prashantgupta24 prashantgupta24 merged commit 203eb21 into main Sep 4, 2025
25 of 32 checks passed
@prashantgupta24 prashantgupta24 deleted the print-tol-diff branch September 4, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants