Skip to content

Conversation

yannicks1
Copy link
Collaborator

@yannicks1 yannicks1 commented Sep 2, 2025

🐛 solve undetected merge conflict with main

There was a undetected merge conflict of #425 and #428. This PR fixes the conflict in the added tests.

@yannicks1
Copy link
Collaborator Author

bot:test

@wallashss
Copy link
Collaborator

LGTM, please rename the title before merge.

@yannicks1 yannicks1 changed the title [PLS MERGE ASAP] 🐛 solve undetected merge conflict with main 🐛 solve undetected merge conflict with main Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@github-actions github-actions bot added the ready label Sep 2, 2025
@yannicks1
Copy link
Collaborator Author

@joerunde should we maybe enforce syncing with main again before merging PRs to prevent bugs like this in the future? I believe the initial reason for dropping it was triggering GHA less frequently, or was there another motivation too?

@yannicks1 yannicks1 merged commit 22a135b into main Sep 2, 2025
19 of 32 checks passed
@yannicks1 yannicks1 deleted the ysc-fix-tests-on-main branch September 2, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants