Skip to content

Conversation

yannicks1
Copy link
Collaborator

[test] 🎨 fix test description string

changes:

  • number of available blocks was missing (note we don't state it if set to 1000 (no restriction)
  • number of available blocks was stated wrongly (8 instead of 4)

Signed-off-by: Yannick Schnider <[email protected]>
@yannicks1
Copy link
Collaborator Author

bot:test

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@github-actions github-actions bot added the ready label Aug 26, 2025
Copy link
Collaborator

@sducouedic sducouedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll need to remember to update in the #409 PR

@yannicks1 yannicks1 merged commit 885046d into main Aug 26, 2025
19 of 32 checks passed
@yannicks1 yannicks1 deleted the ysc-fix-test-description branch August 26, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants