🎨 make max_num_seqs 4 for online test #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For model
ibm-ai-platform/micro-g3.3-8b-instruct-1b:max_num_seqs2 with TP 4 and CB fortest_openai_servingseems to be failing:Some notes:
Earlier we had only BS 2 tested with:
test_openai_servingwhich tested withSBandTP1, 2, 4, andtest_openai_serving_cbwhich tested againstCBbut with noTP.Both of them separately passed, but TP (4) with
CBand BS 2 fortest_spyre_onlineis failing (but TP (2) with CB and BS 2 passes)Also the full model passes:
tests/e2e/test_spyre_online.py::test_openai_serving[max_model_len(256)-max_num_seqs(2)-cb-sendnn-TP(4)-ibm-granite/granite-3.3-8b-instruct] PASSED