Skip to content

Conversation

@yannicks1
Copy link
Collaborator

[cb][tests] 🐛 fix bug in test utils, please merge ASAP

during some test script refactoring, the parameter max_model_len was overridden to always be 256, even if set differently.

Signed-off-by: Yannick Schnider <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@rafvasq rafvasq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@nikolaospapandreou nikolaospapandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yannicks1 yannicks1 merged commit 08afed5 into main Aug 11, 2025
24 checks passed
@yannicks1 yannicks1 deleted the ysc-fix-scheduler-test-utils branch August 11, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants