Skip to content

Conversation

@yannicks1
Copy link
Collaborator

[docs][CB] remove warning that no output correctness is asserted for scheduler step tests

we now do assert output correctness for the scheduling test since #337 , hence this warning should be removed.

@yannicks1 yannicks1 requested a review from rafvasq as a code owner August 5, 2025 12:49
@yannicks1 yannicks1 enabled auto-merge (squash) August 5, 2025 12:49
Copy link
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@github-actions github-actions bot added the ready label Aug 5, 2025
@yannicks1 yannicks1 merged commit 8fab64f into main Aug 5, 2025
24 checks passed
@yannicks1 yannicks1 deleted the ysc-update-docs-cb-testing branch August 5, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants