Skip to content

Conversation

@yannicks1
Copy link
Collaborator

[docs] remove pooling models from supported features

Following up a (late) discussion in #344 about removing the pooling models from the list of supported models as not all all pooling applications are supported, and we already have embedding models in that list (see comment by @maxdebayser : link)

Signed-off-by: Yannick Schnider <[email protected]>
@yannicks1 yannicks1 requested a review from maxdebayser August 4, 2025 07:05
@yannicks1 yannicks1 enabled auto-merge (squash) August 4, 2025 07:05
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@github-actions github-actions bot added the ready label Aug 4, 2025
@yannicks1 yannicks1 merged commit 4d63b70 into main Aug 4, 2025
23 checks passed
@yannicks1 yannicks1 deleted the ysc-fix-doc-table branch August 4, 2025 14:50
@x22x22
Copy link

x22x22 commented Aug 4, 2025

@maxdebayser Could you please review my PR or let me know what else needs to be done? Thank you!
vllm-project/vllm#20837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants