Skip to content

Conversation

@sducouedic
Copy link
Collaborator

@sducouedic sducouedic commented Jul 17, 2025

Two main changes in this PR:

  • Scheduling tests refactoring: convert previously unit-test test_scheduler_cb_steps_tkv to a helper function, and the previously parameters functions of test_scheduler_cb_steps_tkv to unit tests
  • Build doc from tests docstring (continuous batching only), check these pages:

Closes #318
Closes #319

Signed-off-by: Sophie du Couédic <[email protected]>
Signed-off-by: Sophie du Couédic <[email protected]>
Signed-off-by: Sophie du Couédic <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@sducouedic sducouedic changed the title [CB] Refactoring scheduling step-by-step tests [CB] Refactoring scheduling step-by-step inference tests Jul 17, 2025
Signed-off-by: Sophie du Couédic <[email protected]>
Signed-off-by: Sophie du Couédic <[email protected]>
Signed-off-by: Sophie du Couédic <[email protected]>
Signed-off-by: Sophie du Couédic <[email protected]>
@sducouedic sducouedic marked this pull request as ready for review July 17, 2025 20:32
@sducouedic sducouedic changed the title [CB] Refactoring scheduling step-by-step inference tests [CB] Update CB docs + Refactoring scheduling step-by-step inference tests Jul 17, 2025
@sducouedic
Copy link
Collaborator Author

I just noticed that now the cb scheduling tests are skipped, trying to figure out why is this 🤔

@sducouedic
Copy link
Collaborator Author

I just noticed that now the cb scheduling tests are skipped, trying to figure out why is this 🤔

Oh I found out, I didn't know unit tests had to be prefixed with test_. I just learned something 😂

@sducouedic
Copy link
Collaborator Author

thanks for being so reactive in your review for this big PR @prashantgupta24 , I'll finish addressing your comments tomorrow

I see that test_openai_serving_cb is failing, I am not sure if it is related to those changes or if it is something related with multiprocessing, it was already failing in a previous commit and then passing again...

Copy link
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great restructuring Sophie! left a couple of minor comments.

@@ -0,0 +1,10 @@
# End output correctness tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a better title for this section? It would be nice to coincide with the chapter on the left of the page. Currently we have:

End-to-End -> title: End output correctness tests -> file name: e2e_testing.md
Step-by-Step -> title: Scheduler inference steps tests -> file name: scheduling_inference_steps.md
Other Tests -> title: Other tests -> file name: other_tests.md

what about:

Output Tests -> title: Output Tests -> file name: output_tests.md
Scheduler Tests -> title: Scheduler Tests -> file name: scheduler_tests.md
Other Tests -> title: Other tests -> file name: other_tests.md

e.g. making things more uniform?

Copy link
Collaborator Author

@sducouedic sducouedic Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about scheduler_tests only because there is some other test test_cb_max_tokens in test_spyre_cb.py that is also testing the scheduler (but just the constraint), without really belonging to this test suite imo. I want to emphasis that this is somehow "step-by-step correct execution". And it won't be only about the scheduler correctness, on the compiler side it is also required that the compiled graph cab adapt to different scenarios of prompts_length/max_tokens/steps joining.

But I agree the current naming is a bit fuzzy, I changed it a lot

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But output_test is great naming, I change that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the scheduler tests, I renamed everything to scheduler_steps tests 👍

@sducouedic sducouedic force-pushed the cb_param_functions_to_unit_tests branch 3 times, most recently from 8559b35 to c7cc603 Compare July 18, 2025 13:42
Signed-off-by: Sophie du Couédic <[email protected]>
@sducouedic sducouedic force-pushed the cb_param_functions_to_unit_tests branch from c7cc603 to 2b61721 Compare July 18, 2025 13:43
Signed-off-by: Sophie du Couédic <[email protected]>
@sducouedic sducouedic enabled auto-merge (squash) July 18, 2025 13:54
@github-actions github-actions bot added the ready label Jul 18, 2025
@prashantgupta24
Copy link
Collaborator

Last question of whether we want to integrate the test_cb_max_tokens with test_spyre_basic, otherwise I can approve!

Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sducouedic sducouedic merged commit 639295d into main Jul 18, 2025
18 checks passed
@sducouedic sducouedic deleted the cb_param_functions_to_unit_tests branch July 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CB][Testing] Document docstring of scheduling tests [CB][Testing] Convert to unit tests the parameter functions of CB scheduling test function

4 participants