Skip to content

Conversation

@prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Jul 11, 2025

Description

Adding TP to CB tests

Related Issues

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24 prashantgupta24 marked this pull request as ready for review July 16, 2025 18:22
@prashantgupta24 prashantgupta24 requested a review from rafvasq as a code owner July 16, 2025 18:22
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small comments but as-is this addresses the need for more TP test cases with continuous batching 👍

@joerunde
Copy link
Collaborator

TypeError: generate_spyre_vllm_output() missing 1 required positional argument: 'block_size

oof :(

I'd remove from generate_spyre_vllm_output entirely, but also fine w/ passing any old dummy value in

Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 merged commit e18ec15 into main Jul 16, 2025
17 checks passed
@prashantgupta24 prashantgupta24 deleted the cb-with-tp branch July 16, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants