Skip to content

Conversation

@prashantgupta24
Copy link
Collaborator

Description

This PR adds assertions for operations done within the warmup context. Earlier we saw a bug in which the decode warmup was moved outside the warmup context because of one simple indentation issue and it caused a segmentation fault with no clue as to why it was happening.

These assertions should catch the error when running even on CPU.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@sducouedic sducouedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea

Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we addressed this with a refactor to put everything that should be inside the warmup context into its own method. As is the full warmup method here is already ~150 lines and should be broken up anyway

# setup dummy_requests

with _maybe_warmup_context():
    self._dynamic_warmup(dummy_requests)

# the rest of the post-compile warmup

@prashantgupta24 prashantgupta24 enabled auto-merge (squash) July 16, 2025 20:16
@github-actions github-actions bot added the ready label Jul 16, 2025
@prashantgupta24 prashantgupta24 disabled auto-merge July 16, 2025 20:24
Copy link
Collaborator

@yannicks1 yannicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashantgupta24 prashantgupta24 merged commit c9bfad9 into main Jul 17, 2025
19 checks passed
@prashantgupta24 prashantgupta24 deleted the assert-warmup-mode branch July 17, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants