Skip to content

🐛 fixed static batch warmup #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

🐛 fixed static batch warmup #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions vllm_spyre/v1/worker/spyre_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,8 @@ def compile_or_warm_up_model(self) -> None:
logger.info(
"Warming up for prompt length %d, decoding %d tokens with "
"batch size %d", prompt_len, num_decode_tokens, batch_size)
with _maybe_warmup_context():
self._warmup_spyre_fixed_size(prompt_len, num_decode_tokens,
self.restricted_tokens,
batch_size)
self._warmup_spyre_fixed_size(prompt_len, num_decode_tokens,
self.restricted_tokens, batch_size)
all_warmup_end_t = time.time()
all_warmup_total_t = all_warmup_end_t - all_warmup_start_t
self.perf_metrics.log("total warmup time", all_warmup_total_t)
Expand Down Expand Up @@ -537,8 +535,10 @@ def _warmup_spyre_fixed_size(self, prompt_len, num_decode_tokens,

# First full forward pass
logger.info("Warmup forward pass 1/2...")
self._warmup_model_forward_pass(scheduler_output, dummy_requests,
cached_requests, num_decode_tokens)
# The fixed size warmup needs to happen only in here
with _maybe_warmup_context():
self._warmup_model_forward_pass(scheduler_output, dummy_requests,
cached_requests, num_decode_tokens)
self.perf_metrics.log("warmup 1 time",
time.time() - warmup_start_t,
batch_size=batch_size,
Expand Down
Loading