-
Notifications
You must be signed in to change notification settings - Fork 26
📝 update deployment examples, add kserve #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joe Runde <[email protected]>
|
👋 Hi! Thank you for contributing to vLLM support on Spyre. Or this can be done with Now you are good to go 🚀 |
|
bot:test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll read through the RHOAI doc tomorrow, quick note that it's not in .nav.yml though!
|
Thanks! This connects: But this refuses a connection: (I'm probably just missing something simple) |
docs/deploying/rhoai.md
Outdated
| 3. Deploy and Test | ||
|
|
||
| Apply the manifests using `oc apply -f <filename>`: | ||
|
|
||
| ```console | ||
| oc apply -f servingruntime.yaml | ||
| oc apply -f inferenceservice.yaml | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could just include these apply lines in each step above after defining the manifests and then use this step for a "Perform an inference request" example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I went ahead with the heredoc pattern in each section above (oc apply -f - <<EOF) and just linked out to the relevant kserve docs here for how to setup inference with a vllm deployment so we don't have to repeat that info
|
I think there was a way to fix the sign off commit suggestions directly from the PR page, but can't remember 🤔 |
|
yeah that confuses me, since my regular commits (that pass DCO) are all signed off with |
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Joe Runde <[email protected]>
|
@prashantgupta24 for some reason github defaulted to my ibm email for the commit author, but my personal email for the signoff. 🤷 fixes it |
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My last nit, thanks Joe!
Co-authored-by: Rafael Vasquez <[email protected]> Signed-off-by: Joe Runde <[email protected]>
This PR: