[CI] Only build docker image on source changes #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kadner <[email protected]>
|
I'll take a look tomorrow! |
|
Actually I'll let @joerunde take a look at this too in case he had opinions |
|
LGTM too, so long as we keep the job out of the required set for PRs |
joerunde
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Build Dockerworkflow is one of the biggest consumers of Github Action minutes.To preserve our GHA quota, only run Docker image build on PRs that change relevant files:
.github/workflows/build_docker.ymldocker/**vllm_spyre/**/*.pypyproject.tomluv.lock