Skip to content

Conversation

prashantgupta24
Copy link
Collaborator

@prashantgupta24 prashantgupta24 commented Jun 4, 2025

data_parallel_rank added to EngineCoreRequest

Signed-off-by: Prashant Gupta <[email protected]>
Copy link

github-actions bot commented Jun 4, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24
Copy link
Collaborator Author

@sducouedic This happens right after you remove the last backward compatibility check :D

@prashantgupta24 prashantgupta24 merged commit 6466b94 into main Jun 4, 2025
22 checks passed
@prashantgupta24 prashantgupta24 deleted the fix-main-agaaain branch June 4, 2025 17:20
@sducouedic
Copy link
Collaborator

@sducouedic This happens right after you remove the last backward compatibility check :D

I'm sure that's a coincidence 😂
I am wondering why there are no default None values for these parameters, especially if those are optional. This will definitely happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants