Create CODEOWNERS file #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create initial set of code owners to facilitate reviews and (auto) merge process Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
ckadner
requested review from
joerunde,
prashantgupta24,
rafvasq,
tdoublep and
tjohnson31415
Signed-off-by: Christian Kadner <[email protected]>
|
I added a few more contributors to the CODEOWNERS file and added them here for review following Joe's suggestion. Still just a draft! |
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
rafvasq
reviewed
Jun 3, 2025
Signed-off-by: Christian Kadner <[email protected]>
prashantgupta24
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create initial set of code owners to facilitate reviews and (auto) merge process. Following the precedence of vllm main: https://github.com/vllm-project/vllm/blob/main/.github/CODEOWNERS. Ideally we should assign teams to areas of code/expertise as captured in the folder structure of the repo, but short of proper teams, in a small community we can assign individual contributors.
For a more general process, we probably should follow what more established OS communities do and create a process to promote new reviewers/committers periodically after a first pass, where maintainers are chosen from the initial set of project creators. As the community grows, there should be periodic reviews of who is active in reviewing PRs, who makes good code contributions etc. and the current project maintainers nominate new maintainers (committers/reviewers) and then the existing maintainers have a up/down vote to confirm new maintainers. At the same time, maintainers who are no longer active can get put on a emeritus list. Most Apache projects have well thought-out processes https://infra.apache.org/new-committers-guide.html#becoming-a-committer