Skip to content

Conversation

joerunde
Copy link
Collaborator

@joerunde joerunde commented Jun 2, 2025

Looks like I accidentally left in a dd2 target in the dockerfile that's unused

@joerunde joerunde marked this pull request as ready for review June 2, 2025 18:13
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 ✅

@joerunde joerunde merged commit 9255024 into main Jun 2, 2025
21 checks passed
@joerunde joerunde deleted the dockerfile-fixes branch June 2, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants