Skip to content

Conversation

rafvasq
Copy link
Collaborator

@rafvasq rafvasq commented May 27, 2025

  • Adds information about opening issues/bug reports, PR linting, etc. and point to Slack support
  • Remove debugpy doc because it doesn't seem vllm-spyre related (same example here)
  • Copy-edit testing docs

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes. Thanks!

rafvasq added 2 commits May 27, 2025 14:02
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq rafvasq requested a review from prashantgupta24 May 27, 2025 18:09
Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafvasq rafvasq enabled auto-merge (squash) May 27, 2025 19:10
@github-actions github-actions bot added the ready label May 27, 2025
@rafvasq rafvasq merged commit 9eb633e into main May 27, 2025
22 checks passed
@rafvasq rafvasq deleted the add-user-support-docs branch May 27, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants