Skip to content

Conversation

wallashss
Copy link
Collaborator

Accordingly to this documentation: https://docs.github.com/es/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpaths. This should be the way to not run tests when we only update docs.

on:
  push:
    paths-ignore:
      - 'docs/**'

Signed-off-by: Wallas Santos <[email protected]>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@wallashss
Copy link
Collaborator Author

@joerunde @ckadner

Regarding this comment:

# Don't use pull_request.paths filter since this workflow is required for
  # all pull requests on main irrespective of file type or location

Is it okay use ignore-paths then? Am I understand correctly, or I may be missing something?

@wallashss wallashss requested review from ckadner and joerunde May 26, 2025 14:54
@prashantgupta24
Copy link
Collaborator

prashantgupta24 commented May 27, 2025

@wallashss Maybe do a quick check and push a dummy commit on one of the docs to see if the tests run or not on this branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as far as I can tell, the paths-ignore should be the right way to do what you've added here.

@wallashss
Copy link
Collaborator Author

@wallashss Maybe do a quick check and push a dummy commit on one of the docs to see if the tests run or not on this branch?

@prashantgupta24 look: #183

I had to change this PR so it will trigger to other branches besides main.

@wallashss
Copy link
Collaborator Author

@prashantgupta24 did another one right now, changing code. To check if it would trigger the other tests. Looks like okay. A PR to a branch different from main, would not run anyway.

@wallashss
Copy link
Collaborator Author

Reverted the code changes. All green without running the tests.

Previous Action with code changes: https://github.com/vllm-project/vllm-spyre/actions/runs/15281436943/job/42981219120?pr=183

Feel free to play around with this branch @prashantgupta24!

Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think this PR is good then

This reverts commit a1090b5.

Signed-off-by: Wallas Santos <[email protected]>
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) May 27, 2025 18:33
@github-actions github-actions bot added the ready label May 27, 2025
@wallashss wallashss disabled auto-merge May 27, 2025 18:33
@wallashss wallashss enabled auto-merge (squash) May 27, 2025 18:33
@wallashss wallashss merged commit b03650a into main May 27, 2025
23 checks passed
@wallashss wallashss deleted the wallas-ignore-docs branch May 27, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants