-
Notifications
You must be signed in to change notification settings - Fork 26
[CI] Ignore docs for tests #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wallas Santos <[email protected]>
👋 Hi! Thank you for contributing to vLLM support on Spyre.
Or this can be done with
Now you are good to go 🚀 |
@wallashss Maybe do a quick check and push a dummy commit on one of the docs to see if the tests run or not on this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And as far as I can tell, the paths-ignore should be the right way to do what you've added here.
Signed-off-by: Wallas Santos <[email protected]>
@prashantgupta24 look: #183 I had to change this PR so it will trigger to other branches besides main. |
@prashantgupta24 did another one right now, changing code. To check if it would trigger the other tests. Looks like okay. A PR to a branch different from main, would not run anyway. |
Reverted the code changes. All green without running the tests. Previous Action with code changes: https://github.com/vllm-project/vllm-spyre/actions/runs/15281436943/job/42981219120?pr=183 Feel free to play around with this branch @prashantgupta24! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I think this PR is good then
This reverts commit a1090b5. Signed-off-by: Wallas Santos <[email protected]>
Accordingly to this documentation: https://docs.github.com/es/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpaths. This should be the way to not run tests when we only update docs.