Skip to content

Conversation

@sducouedic
Copy link
Collaborator

Disabling caching from within the test doesn't work when running multiple tests. So reverting to skipping the failing test with cache.

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@sducouedic sducouedic force-pushed the restore_skip_warmup_test branch from 5bdd0d6 to 6b0b23f Compare May 23, 2025 11:26
@sducouedic sducouedic requested review from joerunde and waleedqk May 23, 2025 11:30
Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang dang dang :(

@joerunde joerunde merged commit 7b260d0 into main May 23, 2025
17 checks passed
@joerunde joerunde deleted the restore_skip_warmup_test branch May 23, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants