Skip to content

Conversation

@sducouedic
Copy link
Collaborator

Disable compile cache in test_spyre_warmup_shapes because this test fails with cache enabled. Need to debug

@github-actions
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@sducouedic sducouedic requested review from joerunde and waleedqk May 20, 2025 08:37
Copy link
Collaborator

@waleedqk waleedqk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
we only want this test to skip caching currently, and the CI pipeline can run as is without updates required

@sducouedic sducouedic merged commit 35816cd into main May 20, 2025
18 checks passed
@sducouedic sducouedic deleted the test_warmup_disable_caching branch May 20, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants