make mla weight contiguous #646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyu-intel
requested review from
adobrzyn,
afierka-intel,
iboiko-habana,
kamil-kaczor,
ksmusz,
kzawora-intel,
mgawarkiewicz-intel,
michalkuligowski,
vivekgoe and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the MLA (Multi-head Latent Attention) implementation by making weight tensors contiguous during the weight loading phase, eliminating the need for runtime transpose operations during graph execution.
Key Changes:
- Added
process_weights_after_loadingmethod to makeW_UVandW_UK_Ttensors contiguous after weight loading
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xinyu-intel
force-pushed
the
dev/xinyu/contiguous-mla-weight
branch
from
cf7a643 to
7f3a3b9
Compare
Signed-off-by: Xinyu Chen <[email protected]>
✅ CI PassedAll checks passed successfully against the following vllm commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.