Skip to content

Conversation

OneZero-Y
Copy link
Contributor

What type of PR is this?

what's changed

  • Improve rust unit test ,add 6 new unit test files
  • optimize concurrent tests with rayon, Replaced manual std::thread::spawn with rayon::par_iter()

Impact

  • Scope: Test code only

Which issue(s) this PR fixes:

part of #266

Release Notes: Yes/No

- Add 6 new unit test files
- Replace std::thread::spawn with rayon::par_iter

Signed-off-by: OneZero-Y <[email protected]>
Copy link

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 candle-binding

Owners: @rootfs
Files changed:

  • candle-binding/src/core/similarity_test.rs
  • candle-binding/src/core/tokenization_test.rs
  • candle-binding/src/ffi/init_test.rs
  • candle-binding/src/ffi/state_manager_test.rs
  • candle-binding/src/ffi/validation_test.rs
  • candle-binding/src/model_architectures/lora/lora_adapter_test.rs
  • candle-binding/src/classifiers/lora/parallel_engine_test.rs
  • candle-binding/src/core/mod.rs
  • candle-binding/src/ffi/mod.rs
  • candle-binding/src/model_architectures/lora/mod.rs

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@rootfs
Copy link
Collaborator

rootfs commented Oct 18, 2025

thank you @OneZero-Y

i am now much behind, will start once #239 is done

@rootfs rootfs merged commit bb2f77f into vllm-project:feat-candle-refactoring Oct 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants