Install compressed-tensors after llm-compressor #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'always()' function is dangerous. When used, it makes it impossible to cancel a job because it returns true even if the job is canceled. Using "success() || failure()" instead is functionally equivalent in this use-case.
kylesayrs
approved these changes
Oct 7, 2024
dsikka
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
These changes move the separate
compressed-tensorsinstallation to afterllm-compressoris installed, as well as uninstall any existing version first.There is also some very minor cleanup:
pytestcommands so the flag ordering is consistent between themalways()to allow jobs to be cancelable without affecting existing logic/intentionsTEST PLAN:
Branch/PR checks should have the same outcome as
main(unless some of the existing failure are related totransformersspecifically requiring a non-nightly install ofcompressed-tensors).