Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV Cache, E2E Tests #742

Merged
merged 17 commits into from
Dec 16, 2024
Merged

KV Cache, E2E Tests #742

merged 17 commits into from
Dec 16, 2024

Conversation

horheynm
Copy link
Collaborator

@horheynm horheynm commented Oct 1, 2024

SUMMARY:
Create e2e tests for using KVCache

@horheynm horheynm marked this pull request as ready for review October 1, 2024 16:16
Copy link

github-actions bot commented Oct 1, 2024

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

dsikka
dsikka previously approved these changes Oct 2, 2024
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

kylesayrs
kylesayrs previously approved these changes Oct 2, 2024
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should run with nightly runners before merging

@markurtz
Copy link
Collaborator

@kylesayrs has this run with nightly and can we get it landed?

Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this land? @horheynm

@horheynm horheynm dismissed stale reviews from kylesayrs and dsikka via 3bd143d November 21, 2024 03:38
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're changing a bunch of filenames that shouldnt be changed.

@horheynm horheynm changed the title e2e tests KV Cache, E2E Tests Dec 12, 2024
@horheynm
Copy link
Collaborator Author

/ready

Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are any of the configs using the gptq recipe?
Have we confirmed all the configs work?

@horheynm
Copy link
Collaborator Author

@dsikka its ready

@dsikka dsikka merged commit 5c53071 into main Dec 16, 2024
5 of 7 checks passed
@dsikka dsikka deleted the kv-cache-e2e branch December 16, 2024 18:33
dsikka added a commit that referenced this pull request Dec 17, 2024
dsikka added a commit that referenced this pull request Dec 17, 2024
horheynm pushed a commit that referenced this pull request Dec 20, 2024
horheynm pushed a commit that referenced this pull request Dec 20, 2024
horheynm pushed a commit that referenced this pull request Dec 20, 2024
rahul-tuli pushed a commit that referenced this pull request Dec 23, 2024
* e2e tests

* name

* merge main and edit configs/bash script to interate inside subfolders

* revert pytest command

* revert config structure to main

* revert configs

* revert

* revert

* revert test input arg

* comments

* add gptq script

---------

Co-authored-by: Dipika Sikka <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants