-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KV Cache, E2E Tests #742
KV Cache, E2E Tests #742
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should run with nightly runners before merging
@kylesayrs has this run with nightly and can we get it landed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this land? @horheynm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're changing a bunch of filenames that shouldnt be changed.
c3bf7dd
to
fe61a9a
Compare
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of the configs using the gptq recipe?
Have we confirmed all the configs work?
49eae7d
to
1cdb4c6
Compare
@dsikka its ready |
* e2e tests * name * merge main and edit configs/bash script to interate inside subfolders * revert pytest command * revert config structure to main * revert configs * revert * revert * revert test input arg * comments * add gptq script --------- Co-authored-by: Dipika Sikka <[email protected]> Signed-off-by: Rahul Tuli <[email protected]>
SUMMARY:
Create e2e tests for using KVCache