-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Prepare KD Models when Saving #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
Ready to go, just need to merge prerequisites first |
horheynm
previously approved these changes
Sep 26, 2024
Is this ready for review? |
@dsikka Yes, ready for review but in draft mode because it should not be merged until the prereqs are merged |
rahul-tuli
previously approved these changes
Oct 4, 2024
The base branch was changed.
rahul-tuli
approved these changes
Oct 4, 2024
mgoin
approved these changes
Oct 7, 2024
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
Co-authored-by: kylesayrs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prerequisites
Changes
named_modules
function. The test failures arose becauseget_state_dict_offloaded_model(model)
usesnamed_modules
rather thanmodel.state_dict()
to gather all the state dict tensors, and the KD wrapper did not account for this use case.Testing
tests/llmcompressor/transformers/finetune/test_oneshot_then_finetune.py
now passes without shared tensor conflicts