Add tests for examples #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarbuzzi
force-pushed
the
add-examples-tests
branch
3 times, most recently
from
915cb31 to
e123f8a
Compare
dbarbuzzi
force-pushed
the
add-examples-tests
branch
2 times, most recently
from
f010ffa to
1eadb8a
Compare
dbarbuzzi
force-pushed
the
add-examples-tests
branch
from
d5ef312 to
a2b961e
Compare
dsikka
reviewed
Sep 23, 2024
dsikka
reviewed
Sep 23, 2024
dsikka
approved these changes
Sep 27, 2024
rahul-tuli
approved these changes
Sep 27, 2024
mgoin
approved these changes
Sep 27, 2024
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
) * add error * Update src/compressed_tensors/quantization/quant_args.py Co-authored-by: Dipika Sikka <[email protected]> * remove extra line * fix invalid configs it tests --------- Co-authored-by: Dipika Sikka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR adds automated tests for (most of) the content in the
examplesfolder:examples/finetuningis not coveredexamples/quantizing_moe/deepseek_moe_w4a16.pyis covered but skipped due to exceptionally long run timeThe general testing approach covers some of the 'install' snippets as well as the example commands in the READMEs, as well as running the various other example scripts within the covered folders. The commands/scripts are plainly executed and deemed passing as long as the execution completes successfully (i.e., exit code 0) — no further validation occurs.
TEST PLAN:
Automation is configured internally. There is one failure that is reported and unrelated to the automation code itself.