Fix recipe nested in configs #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
kylesayrs
changed the title
dsikka
reviewed
Sep 4, 2024
| @@ -68,54 +68,48 @@ def _validate_test_config(config: dict): | |||
| # Set cadence in the config. The environment must set if nightly, weekly or commit | |||
| # tests are running | |||
| def parse_params( | |||
| path: str, type: Optional[str] = None | |||
| configs_directory: Union[list, str], type: Optional[str] = None | |||
There was a problem hiding this comment.
can you confirm that this runs the e2e tests correctly?
horheynm
approved these changes
Sep 5, 2024
|
Approved contingent on Dipika's comment about end to end testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
parse_paramsrather than recursing