Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Xenova model stub with nm-testing model stub #1239

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

kylesayrs
Copy link
Collaborator

Purpose

Changes

  • Use self-hosted model stub

Signed-off-by: Kyle Sayers <[email protected]>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs added the ready When a PR is ready for review label Mar 10, 2025
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the other model loading change right?

@kylesayrs
Copy link
Collaborator Author

@dsikka No, as of 5 minutes ago this self-hosted model fixes the bug which was present on the original Xenova model

@dsikka
Copy link
Collaborator

dsikka commented Mar 10, 2025

@dsikka No, as of 5 minutes ago this self-hosted model fixes the bug which was present on the original Xenova model

lolz

@dsikka dsikka enabled auto-merge (squash) March 10, 2025 21:58
@dsikka dsikka merged commit 5307947 into main Mar 10, 2025
9 checks passed
@dsikka dsikka deleted the kylesayrs/replace-self-hosted branch March 10, 2025 22:20
brian-dellabetta pushed a commit that referenced this pull request Mar 10, 2025
## Purpose ##
* Fix tests which break as a result of
https://github.com/vllm-project/llm-compressor/pull/new/kylesayrs/replace-self-hosted

## Changes ##
* Use self-hosted model stub

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants