Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmetic] Rename data_args to dataset_args #1206

Merged
merged 10 commits into from
Mar 5, 2025
Merged

[Cosmetic] Rename data_args to dataset_args #1206

merged 10 commits into from
Mar 5, 2025

Conversation

horheynm
Copy link
Collaborator

@horheynm horheynm commented Feb 27, 2025 •
edited
Loading

Order of reviews:
#1206 <-- Here
#1207
#1209
#1212
#1214

SUMMARY:
Rename data_args to dataset_args

TEST PLAN:
Pass tests
FInd data_args using grep

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@horheynm horheynm added the ready When a PR is ready for review label Feb 28, 2025
This was referenced Feb 28, 2025
Open
Merged
Merged
Merged
@horheynm horheynm marked this pull request as ready for review February 28, 2025 21:03
brian-dellabetta
brian-dellabetta previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do a linter check here or will the tests capture full coverage of the changes?

dsikka
dsikka reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just changing variable names, not the actual class name?

@horheynm
Copy link
Collaborator Author

horheynm commented Mar 3, 2025

Yes

This is just changing variable names, not the actual class name?

dsikka pushed a commit that referenced this pull request Mar 3, 2025
@horheynm
[Training] Decouple Argument parser (#1207)
7bb517f 
Order of reviews:
#1206
#1207 <-- Here
#1209 
#1212
#1214 

SUMMARY:
* Decouple arg parser to be used for both oneshot and train

TEST PLAN:
* Pass tests
@horheynm
fix merge main
4cf71e9 
Signed-off-by: George Ohashi <[email protected]>
brian-dellabetta
brian-dellabetta requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some things were changed in a find+replace that shouldn't have been

@horheynm
comments
5177a2b 
Signed-off-by: George Ohashi <[email protected]>
@dsikka dsikka enabled auto-merge (squash) March 5, 2025 14:55
@dsikka dsikka merged commit 391b202 into main Mar 5, 2025
8 checks passed
@dsikka dsikka deleted the datasetargs branch March 5, 2025 15:27
dsikka pushed a commit that referenced this pull request Mar 5, 2025
@horheynm
[Training] Datasets - update Module (#1209)
8fc6012 
Order of reviews:
#1206
#1207
#1209 <-- Here
#1212
#1214 

SUMMARY:
* Move dataset logic out of transformers module
`src/llmcompressor/transformers/finetune/data/data_helpers.py`, add it
to `src/llmcompressor/datasets/utils.py`


TEST PLAN:
Pass tests
dsikka pushed a commit that referenced this pull request Mar 6, 2025
@horheynm
[Training] Unifying Preprocess + Postprocessing logic for Train/Onesh…
9d82f35 
…ot (#1212)

Order of reviews:
#1206
#1207
#1209
#1212  <-- Here
#1214

SUMMARY:
* Move the preprocessing and postprocessing logic out of
`src/llmcompressor/transformers/finetune/text_generation.py` and into
`src/llmcompressor/entrypoints/utils.py`

TEST PLAN:
Pass tests
brian-dellabetta pushed a commit that referenced this pull request Mar 10, 2025
@horheynm @brian-dellabetta
[Training] Unifying Preprocess + Postprocessing logic for Train/Onesh…
0761f5e 
…ot (#1212)

Order of reviews:
#1206
#1207
#1209
#1212  <-- Here
#1214

SUMMARY:
* Move the preprocessing and postprocessing logic out of
`src/llmcompressor/transformers/finetune/text_generation.py` and into
`src/llmcompressor/entrypoints/utils.py`

TEST PLAN:
Pass tests

Signed-off-by: Brian Dellabetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@dsikka dsikka dsikka approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horheynm @brian-dellabetta @dsikka