Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Callbacks] Remove on_update #1199

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Simplify modifier lifecycle

Prerequisites

Changes

  • Change the silent nullop when a modifier receives an event but hasn't been initialized
  • Trigger on_event between starting and stopping
  • Rename on_update to on_event to remove the concept of "updating" a modifier

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
@vllm-project vllm-project deleted a comment from github-actions bot Feb 26, 2025
@kylesayrs kylesayrs self-assigned this Feb 26, 2025
@kylesayrs kylesayrs changed the base branch from main to kylesayrs/remove-leave_enabled February 26, 2025 18:39
Base automatically changed from kylesayrs/remove-leave_enabled to main March 7, 2025 18:23
@kylesayrs kylesayrs dismissed brian-dellabetta’s stale review March 7, 2025 18:23

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants