Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2of4 Apply Example #1181

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix 2of4 Apply Example #1181

merged 2 commits into from
Feb 25, 2025

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Feb 20, 2025

Summary

  • Fix typo
  • Fix info log at the end of the script to no longer be cut off

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka changed the title Fix 2o4 Example Fix 2of4 Example Feb 20, 2025
@dsikka dsikka changed the title Fix 2of4 Example Fix 2of4 Apply Example Feb 20, 2025
kylesayrs
kylesayrs approved these changes Feb 22, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making one logger.info call with a string separated by \n

@dsikka dsikka added the ready When a PR is ready for review label Feb 25, 2025
@dsikka dsikka enabled auto-merge (squash) February 25, 2025 00:51
@dsikka dsikka merged commit f326cd4 into main Feb 25, 2025
7 checks passed
@dsikka dsikka deleted the fix_typo branch February 25, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsikka @brian-dellabetta @kylesayrs