-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused/duplicated/non-applicable utils from pytorch/utils/helpers #1174
Conversation
Signed-off-by: Kyle Sayers <[email protected]>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note, I do worry with how much we are able to remove here and how much means we have restricted functionality, so would like to look through in more detail to designate what may be due to restricted functionality we'll need to add back in the future and what is fully migraged functionality either due to newer framework version or migration to compressed tensors
@markurtz I've kept any utils functions that I saw as might having some use in the future. Even if we remove a function that is used in the future, it can be added back when it's needed. |
❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose
src/llmcompressor/pytorch/utils/helpers.py
Changes
pytest.mark.unit
to helpers unit testsTesting
grep -r "from llmcompressor.pytorch.utils" src/ tests/ examples/