Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vLLM e2e tests #117
Add vLLM e2e tests #117
Changes from 13 commits
599afa2
1661f7c
d9d687b
c8dc2a9
79281f5
f49f9b4
ff01253
b55d5e7
7e247b5
09bd1ed
2c6beb0
6a94670
21fc505
5820a4b
2357493
98346eb
1a078b6
af946f2
0766c1a
45f99c2
0abaf11
d6625dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a test for tp>1 is also a good idea if we can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah I think that'll be a follow-up test since the structure will change a bit to deal with tp>1 with the same process
I do think that's more of a vLLM test. If anything, we could extend this to publish test models which are then pulled down for all vllm tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic for perplexity tests can be borrowed from
https://github.com/vllm-project/llm-compressor/blob/main/tests/llmcompressor/transformers/compression/test_quantization.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest running gsm8k on 200 samples