Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifecycle initialized_structure attribute #1156

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Remove lifecycle initialized_structure attribute #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8276ece
remove attribute
kylesayrs Feb 14, 2025
c5b3f7f
Merge branch 'main' into kylesayrs/remove-initialized_structure
dsikka Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/llmcompressor/core/lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class CompressionLifecycle:
modifiers: List[StageModifiers] = field(default_factory=list)
event_lifecycle: Optional[EventLifecycle] = None

initialized_structure: bool = False
initialized_: bool = False
finalized: bool = False

Expand All @@ -68,7 +67,6 @@ def reset(self):
self.modifiers = []
self.event_lifecycle = None

self.initialized_structure = False
self.initialized_ = False
self.finalized = False
logger.info("Compression lifecycle reset")
Expand All @@ -94,7 +92,6 @@ def pre_initialize_structure(self, **kwargs) -> List[Any]:
if data is not None:
mod_data.append(data)

self.initialized_structure = True
applied_stage_names = [mod.unique_id for mod in self.modifiers if mod.applied]
self.recipe_container.update_applied_stages(applied_stage_names)
logger.info(
Expand Down
1 change: 0 additions & 1 deletion tests/llmcompressor/transformers/finetune/test_session_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,4 @@ def test_mixin_session_init(mixin_trainer):
mixin_trainer.initialize_session(epoch=0.0, checkpoint=None)
session = active_session()

assert not session.lifecycle.initialized_structure
assert session.lifecycle.initialized_