Update finetune and oneshot tests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
reviewed
Aug 28, 2024
Comment on lines
+117
to
120
| - name: "🔬 Running transformers tests" | ||
| if: always() && steps.install.outcome == 'success' | ||
| run: | | ||
| pytest tests/llmcompressor/transformers/compression -v |
There was a problem hiding this comment.
What about the tests under obcq/gptq/oneshot/sparsification?
There was a problem hiding this comment.
They're all running. Lines 117 onwards. Just separating them out into separate steps
| device: "auto" | ||
| device: "cuda:0" |
There was a problem hiding this comment.
What was the error you were getting with auto? I think we want at least one test confirming that auto is functional
There was a problem hiding this comment.
"Unspecified CUDA launch errors" - this was on an a100
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
…ue with the W4A8 representation to have dynamic token for activations (vllm-project#114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
integrationtests asunitcuda: 0