Skip to content

Add --version flag to guidellm CLI #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 1, 2025

Conversation

Harshith-umesh
Copy link
Collaborator

Implements a --version flag for the GuideLLM CLI that displays the current version and exits cleanly.
The --version flag is one of the most fundamental and expected features of any CLI tool. It's typically the first flag I try when exploring a new command-line application .

Usage

guidellm --version
# Output: guidellm version: 0.3.0.dev40

The version flag also appears in help output:

guidellm --help

Testing

Wrote 7 unit tests which pass successfully:

pytest tests/unit/test_cli.py -v

Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline. Needs rework.

Harshith-umesh and others added 5 commits August 1, 2025 13:48
Signed-off-by: Harshith-umesh <[email protected]>
Signed-off-by: Harshith-umesh <[email protected]>
…ect#230)

This PR adds the ability to configure custom request headers and control
SSL certificate verification when running benchmarks.

* The OpenAIHTTPBackend now supports passing custom headers and a verify
flag to disable SSL verification.
* Headers are now merged with the following precedence: CLI arguments
(--backend-args), scenario file arguments, environment variables, and
then default values.
* Headers can be removed by setting their value to null in the
--backend-args JSON string.
* The --backend-args help text has been updated with an example of how
to use these new features.
* New documentation has been added for the CLI, configuration options,
and supported data formats.
* Unit tests have been added to verify the new header and SSL
verification logic, as well as the CLI argument parsing.

This provides a way to benchmark targets that require custom
authentication, other headers, or use self-signed SSL certificates.

Signed-off-by: Elijah DeLee <[email protected]>
* Drop the container entrypoint script as GuideLLM has had native
support for its features since vllm-project#99
* Make containerfile more rebuild friendly based on vllm-project#213 
* Drop the ENV default scenario as it is confusing to users setting CLI
args

Closes: vllm-project#213

---------

Signed-off-by: Samuel Monson <[email protected]>
Signed-off-by: Harshith-umesh <[email protected]>
@Harshith-umesh Harshith-umesh requested a review from sjmonson August 1, 2025 18:03
@sjmonson sjmonson merged commit 71f1e3c into vllm-project:main Aug 1, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants