Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Fixed kubectl commands for install of components #744

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jolfr
Copy link
Contributor

@jolfr jolfr commented Feb 25, 2025

Pull Request Description

Changed kubectl apply to kubectl create commands to avoid kubernetes annotation limit.

Related Issues

Resolves: #743

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@jolfr jolfr force-pushed the jolfr/bug_fix/docs/getting_started branch from ad95a5d to bce0ec5 Compare February 26, 2025 00:51
@jolfr jolfr changed the title [Docs]: Updated Getting Started Docs [Docs]: Fixed kubectl commands for install of components Feb 26, 2025
@jolfr jolfr marked this pull request as ready for review February 26, 2025 00:55
@jolfr jolfr force-pushed the jolfr/bug_fix/docs/getting_started branch from bce0ec5 to 31c14b9 Compare February 26, 2025 01:07
@jolfr jolfr requested a review from Jeffwan February 26, 2025 01:08
@Jeffwan Jeffwan merged commit 6eb546a into vllm-project:main Feb 26, 2025
2 checks passed
@jolfr jolfr deleted the jolfr/bug_fix/docs/getting_started branch February 26, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying the charts on gke has an error
2 participants