Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete the 'make generate' command #711

Merged
merged 1 commit into from
Feb 19, 2025
Merged

complete the 'make generate' command #711

merged 1 commit into from
Feb 19, 2025

Conversation

kerthcet
Copy link
Collaborator

Pull Request Description

Make sure the code-generator works as expected.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@kerthcet kerthcet requested a review from Jeffwan February 19, 2025 08:59
@kerthcet
Copy link
Collaborator Author

Failed by TestBaseModelInferenceFailures/Invalid_API_Key again.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 19, 2025

@varungup90 will help double check the e2e issue.

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@Jeffwan Jeffwan merged commit 049b060 into main Feb 19, 2025
18 of 19 checks passed
@Jeffwan Jeffwan deleted the feat/webhooks branch February 19, 2025 22:28
varungup90 pushed a commit that referenced this pull request Feb 20, 2025
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: Varun Gupta <[email protected]>
varungup90 pushed a commit that referenced this pull request Feb 20, 2025
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: Varun Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants