Use response buffer to address stream request issue #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResponseBody.EndOfStream sometimes is false even we use buffered mode. Current implementation does not take this into the consideration. Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
force-pushed
the
jiaxin/unexpected-eof
branch
from
c50369c to
6ddf774
Compare
|
As we have to cut v0.2.0 release this weekend, I will merge this one and we can review this changes next week |
gangmuk
pushed a commit
that referenced
this pull request
Feb 19, 2025
* Increase the connection bufferLimit to avoid end_of_stream=false case ResponseBody.EndOfStream sometimes is false even we use buffered mode. Current implementation does not take this into the consideration. Signed-off-by: Jiaxin Shan <[email protected]> * Use a response buffer to resolve the end_of_stream issue Signed-off-by: Jiaxin Shan <[email protected]> --------- Signed-off-by: Jiaxin Shan <[email protected]>
varungup90
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Increase the connection bufferLimit to avoid end_of_stream=false case ResponseBody.EndOfStream sometimes is false even we use buffered mode. Current implementation does not take this into the consideration. Signed-off-by: Jiaxin Shan <[email protected]> * Use a response buffer to resolve the end_of_stream issue Signed-off-by: Jiaxin Shan <[email protected]> --------- Signed-off-by: Jiaxin Shan <[email protected]> Signed-off-by: Varun Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
After this change, the e2e flaky issue should be gone
Related Issues
Resolves: #675
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.