Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter active pods before metrics calculation #629

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Feb 5, 2025

Pull Request Description

This is to address scenarios like this #617. the http curl failure may break the reconcilation and scaling action is skipped.

Related Issues

Resolves: #617

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

This is to address scenarios like this #617. the http curl failure may break the reconcilation and scaling action is skipped.

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan requested a review from nwangfw February 5, 2025 06:23
@nwangfw
Copy link
Collaborator

nwangfw commented Feb 5, 2025

Looks good to me. Adding pod status filtering addresses this issue.

@Jeffwan Jeffwan merged commit 60c4742 into main Feb 5, 2025
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/fix-autoscaler-pending-pod-bug branch February 5, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants