Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Push images to Github container registry #246

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Sep 27, 2024

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #227

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan force-pushed the jiaxin/ghr_support branch 3 times, most recently from 3ef62f0 to 5a6b334 Compare September 27, 2024 06:02
@Jeffwan Jeffwan changed the title [DO NOT MERGE] Test multi-upload docker image [CI] Push images to Github container registry Sep 27, 2024
@Jeffwan Jeffwan requested a review from brosoul September 27, 2024 06:25
@brosoul
Copy link
Collaborator

brosoul commented Sep 27, 2024

lgtm

@Jeffwan Jeffwan merged commit bad1f1f into main Sep 27, 2024
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/ghr_support branch September 27, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Publish container images in Github Container Registry
2 participants