Add validation for username and rpm/tpm negative value #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Sep 26, 2024
| @@ -54,6 +54,10 @@ func GetUser(u User, redisClient *redis.Client) (User, error) { | |||
| } | |||
|
|
|||
| func SetUser(u User, redisClient *redis.Client) error { | |||
| if u.Rpm < 0 || u.Tpm < 0 { | |||
| return fmt.Errorf("rpm or tpm can not negative") | |||
There was a problem hiding this comment.
what's the http error to the client for this case now?
There was a problem hiding this comment.
internal server error: 500
There was a problem hiding this comment.
should it be something like invalid argument? 400
There was a problem hiding this comment.
Good point. I will audit all endpoints and their return error codes.
Jeffwan
approved these changes
Sep 26, 2024
|
The challenge looks good to me and feel free to merge it. |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Add validation for username and rpm/tpm negative value * update error code to 500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234