Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AI Runtime exist model check #198

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Conversation

brosoul
Copy link
Collaborator

@brosoul brosoul commented Sep 20, 2024

Pull Request Description

Add AI Runtime exist model check

  • Before downloading the file, check the meta file under .cache to verify if the file already exists
  • add DOWNLOADER_FORCE_DOWNLOAD and DOWNLOADER_CHECK_FILE_EXIST to control whether the above verification logic is enabled or not

Example:
First time downloading files from S3
image

Download the file again from S3 to the same path
image

Related Issues

Resolves: #149

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@brosoul brosoul requested a review from Jeffwan September 20, 2024 17:10
@brosoul brosoul force-pushed the linhui/avoid-repeat-download branch from 227fc2f to cd76f73 Compare September 21, 2024 01:27
@Jeffwan Jeffwan merged commit 7ca555a into main Sep 21, 2024
7 checks passed
@Jeffwan Jeffwan deleted the linhui/avoid-repeat-download branch September 21, 2024 04:46
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* add filename desc in download progress bar

* feat: add file exist check and force download options

* style: lint and format

* add default envs value

* refact: extract need_to_download from tos and s3

* test: add test case about download utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Runtime checks if the file to be downloaded exists
2 participants