-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add routing for model adapter #183
Conversation
Do we need to create |
We can not create HTTProute for lora since HTTProute needs a backend ref which is a service. Given that, I have switched to always using targetpod for every query and pods are fetched from internal cache to save time. Going forward we do not need to create httproute, I will remove that in next PR. Edit: added a TODO in model router controller. |
@varungup90 We do create endpoint and service for each model adapter. The purpose is to make sure all model entrypoint is service. The difference part is it use headless service in that case. Does HTTPRoute works with such setting? |
updated to add/delete httproute based on model adapter. |
I didn't see update in model adapter controller? Did you push the commits? |
It seems HTTPRoute is still managed in model router. It's ok at this moment. The downside is user have to use some labels which could be encapsulated inside the controller by us. Let's make necessary refactor later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
* Add routing for model adapter * nit: logging * nit: gateway error response code refactoring * code review comments * add/delete httproute for model adapter * nit --------- Co-authored-by: varungupta <[email protected]>
#146