Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Rename env in runtime #176

Merged
merged 3 commits into from
Sep 13, 2024
Merged

[Misc] Rename env in runtime #176

merged 3 commits into from
Sep 13, 2024

Conversation

brosoul
Copy link
Collaborator

@brosoul brosoul commented Sep 13, 2024

Pull Request Description

Rename env name to add DOWNLOADER_ prefix name

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 13, 2024

@brosoul please rebase the main and update the PR.

@brosoul
Copy link
Collaborator Author

brosoul commented Sep 13, 2024

@brosoul please rebase the main and update the PR.

done

@brosoul brosoul force-pushed the linhui/rename-runtime-env branch from 3c95ff7 to be1248a Compare September 13, 2024 03:33
@brosoul
Copy link
Collaborator Author

brosoul commented Sep 13, 2024

After discussion, we have decided to manage variable names by adding prefixes such as DOWNLOADER_ before the original environment as variable names.

@brosoul brosoul merged commit 5f590ae into main Sep 13, 2024
4 checks passed
@brosoul brosoul deleted the linhui/rename-runtime-env branch September 13, 2024 06:42
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* misc: rename env variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants