Model adapter controller improvement and refactor #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move utils and resource creation to separate files for easy testing 2. Optimize the existing controller codes
varungup90
reviewed
Sep 6, 2024
varungup90
reviewed
Sep 6, 2024
varungup90
reviewed
Sep 9, 2024
| LastTransitionTime: metav1.Now(), | ||
| }) | ||
| if err := r.Status().Update(ctx, instance); err != nil { | ||
| klog.InfoS("Got error when updating status", "error", err, "ModelAdapter", instance) |
There was a problem hiding this comment.
ErrorS? I noticed there are few more places where Info is used for logging error.
There was a problem hiding this comment.
nice catch. it should be error. Let's have a clean up in this story #69
varungup90
approved these changes
Sep 9, 2024
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Update model adapter CRD with more fields * Update the generated clientset * Improve the model adapter controller quality 1. Move utils and resource creation to separate files for easy testing 2. Optimize the existing controller codes * Refactor the reconcileLoading method * Fix the lint error * Fix some failed unit tests * Add missing license files * Address review feedbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Related Issues
Resolves: #41 #51 part of #136
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.