Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix the lint issues and tests #75

Closed
M00nF1sh opened this issue Aug 8, 2024 · 0 comments · Fixed by #77
Closed

[CI] Fix the lint issues and tests #75

M00nF1sh opened this issue Aug 8, 2024 · 0 comments · Fixed by #77

Comments

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Aug 8, 2024

🐛 Describe the bug

Currently both make lint and make test will fail due to various issues like styling or error checks.
We should fix them to enable development and start to enforce lint & correctness tests via CI(#74)

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Fix the golang lint issues vllm-project/aibrix
1 participant
@M00nF1sh