Skip to content

Commit

Permalink
fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
varungupta authored and varungupta committed Aug 28, 2024
1 parent 6d21218 commit e9d0b40
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 8 deletions.
16 changes: 11 additions & 5 deletions pkg/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ func NewCache(stopCh <-chan struct{}) *Cache {
panic(err)
}

v1alpha1scheme.AddToScheme(scheme.Scheme)
if err := v1alpha1scheme.AddToScheme(scheme.Scheme); err != nil {
panic(err)
}

k8sClientSet, err := kubernetes.NewForConfig(config)
if err != nil {
Expand Down Expand Up @@ -116,17 +118,21 @@ func NewCache(stopCh <-chan struct{}) *Cache {
podToModelAdapterMapping: map[string]map[string]struct{}{},
}

podInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
if _, err := podInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: instance.addPod,
UpdateFunc: instance.updatePod,
DeleteFunc: instance.deletePod,
})
}); err != nil {
panic(err)
}

modeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
if _, err = modeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: instance.addModel,
UpdateFunc: instance.updateModel,
DeleteFunc: instance.deleteModel,
})
}); err != nil {
panic(err)
}
})

return &instance
Expand Down
6 changes: 3 additions & 3 deletions pkg/controller/modeladapter/scheduling/leastadapters.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func NewLeastAdapters(c *cache.Cache) Scheduler {

func (r leastAdapters) SelectPod(ctx context.Context, pods []v1.Pod) (*v1.Pod, error) {
modelAdapterCountMin := math.MaxInt
selectedPod := &v1.Pod{}
selectedPod := v1.Pod{}
podMap := r.cache.GetPods()
podToModelAdapterMapping := r.cache.GetPodToModelAdapterMapping()

Expand All @@ -49,12 +49,12 @@ func (r leastAdapters) SelectPod(ctx context.Context, pods []v1.Pod) (*v1.Pod, e

modelAdapters := podToModelAdapterMapping[pod.Name]
if len(modelAdapters) < modelAdapterCountMin {
selectedPod = &pod
selectedPod = pod
modelAdapterCountMin = len(modelAdapters)
}
}

klog.Infof("pod selected with least model adapters: %s", selectedPod.Name)

return selectedPod, nil
return &selectedPod, nil
}

0 comments on commit e9d0b40

Please sign in to comment.