Skip to content

Commit

Permalink
Increase the connection bufferLimit to avoid end_of_stream=false case
Browse files Browse the repository at this point in the history
ResponseBody.EndOfStream sometimes is false even we use buffered mode. Current implementation does not take this into the consideration.

Signed-off-by: Jiaxin Shan <[email protected]>
  • Loading branch information
Jeffwan committed Feb 14, 2025
1 parent c4060bb commit 97dfb62
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion config/gateway/gateway.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
kind: Gateway
name: aibrix-eg
connection:
bufferLimit: 262144
bufferLimit: 1048576
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyExtensionPolicy
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/routing_strategy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/openai/openai-go"
"github.com/openai/openai-go/option"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestPrefixCacheModelInference(t *testing.T) {
Expand Down Expand Up @@ -63,7 +64,7 @@ func getTargetPodFromChatCompletion(t *testing.T, message string) string {
}),
Model: openai.F(modelName),
})
assert.NoError(t, err, "chat completitions failed")
require.NoError(t, err, "chat completitions failed %v", err)
assert.Equal(t, modelName, chatCompletion.Model)

return dst.Header.Get("target-pod")
Expand Down

0 comments on commit 97dfb62

Please sign in to comment.